Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reasons to upgrade to core-js version 3 are many, mainly the improved Babel integration.
In our case, we had a theme failing on Internet Explorer 11, and it boiled down to the fact that core-js version 2 does not provide polyfill for
NodeList.forEach
method. Version 3 of core-js provides this polyfill.If only Cornerstone was using core-js version 3 out of the box, we would not have ran into that issue.
Tickets / Documentation
Screenshots (if appropriate)
⬇️ Comparison from core-js's README for v2 and v3:
⬇️ Although NodeList usage is properly detected, core-js version 2 is missing polyfills for IE 11.