Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default instrument for add/edit payment method #1374

Merged
merged 1 commit into from
Oct 31, 2018
Merged

default instrument for add/edit payment method #1374

merged 1 commit into from
Oct 31, 2018

Conversation

jonathandelefortrie
Copy link

@jonathandelefortrie jonathandelefortrie commented Oct 31, 2018 •
edited
Loading

What?

Add default instrument checkbox to edit and add form.

  • Add html and css for single checkbox, default instrument.
  • Capture form data on ADD and transform to boolean.
  • Fix html credit card for tabulation navigation.
  • Fix for states reload list via ajax.

Tickets / Documentation

Screenshots (if appropriate)

Add Payment Method
screen shot 2018-10-31 at 3 31 23 pm

Edit Payment Method
screen shot 2018-10-31 at 3 33 27 pm

List Payment Methods Tile
screen shot 2018-10-31 at 3 33 14 pm

@bigbot
Copy link

bigbot commented Oct 31, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@jonathandelefortrie jonathandelefortrie changed the title (WIP) default instrument for add/edit payment method default instrument for add/edit payment method Oct 31, 2018
@jonathandelefortrie
Copy link
Author

Hey @danieldelcore @junedkazi , this PR is for the last piece of work for vaulting (default instrument). If you can have a look it that would great. Thanks

danieldelcore
danieldelcore approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@danieldelcore danieldelcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@danieldelcore danieldelcore merged commit e0d8dd7 into bigcommerce:payment-methods-feature Oct 31, 2018
@jonathandelefortrie jonathandelefortrie mentioned this pull request Nov 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

@danieldelcore danieldelcore danieldelcore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathandelefortrie @bigbot @junedkazi @danieldelcore