Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete payment method #1348

Merged
merged 1 commit into from
Sep 18, 2018
Merged

delete payment method #1348

merged 1 commit into from
Sep 18, 2018

Conversation

jonathandelefortrie
Copy link

What?

Bind delete button FE/BE: the click will trigger window confirm, on confirming a post request will be sent then redirect to the credit card listing.

Tickets / Documentation

@bigcommerce/payments @jackosaurus

@bigbot
Copy link

bigbot commented Sep 16, 2018

Autotagging @bigcommerce/storefront-team @davidchin

danieldelcore
danieldelcore approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@danieldelcore danieldelcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM
@junedkazi, would you be able to have a look also?

@danieldelcore danieldelcore merged commit efce773 into bigcommerce:payment-methods-feature Sep 18, 2018
@jonathandelefortrie jonathandelefortrie mentioned this pull request Nov 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

@danieldelcore danieldelcore danieldelcore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathandelefortrie @bigbot @junedkazi @danieldelcore