STENCIL-3672 - Upgrade dependencies #1069
Conversation
| @@ -9,6 +9,22 @@ | |||
| "no-alert": 0, | |||
| "consistent-return": 0, | |||
| "max-len": 0, | |||
| "import/first": 0, | |||
There was a problem hiding this comment.
these new additions are here so that we don't need to fix all these lint issues from the new version of airbnb's linter which marks them as errors by default
There was a problem hiding this comment.
Before adding this, can you try using eslint --fix option? to see what can be automatically fixed
There was a problem hiding this comment.
@mcampa i ran through and tried fix after removing each of these one-by-one and was able to auto-fix a few of them. we could create tickets or issues to go in and correct the others
| @@ -156,7 +156,7 @@ class FacetedSearch { | |||
| const id = $navList.attr('id'); | |||
|
|
|||
| // Toggle depending on `collapsed` flag | |||
| if (_.contains(this.collapsedFacetItems, id)) { | |||
| if (_.includes(this.collapsedFacetItems, id)) { | |||
There was a problem hiding this comment.
lodash got rid of _.contains in favor of _.includes
| @@ -5,58 +5,60 @@ | |||
| "private": true, | |||
| "author": "BigCommerce", | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@bigcommerce/stencil-utils": "^1.0.7", | |||
There was a problem hiding this comment.
webpack now complains about all of these deps being in devDeps and says to move them here
package.json
Outdated
| "grunt-karma": "^0.12.2", | ||
| "eslint": "^4.5.0", | ||
| "eslint-config-airbnb": "^15.1.0", | ||
| "eslint-plugin-react": "^7.3.0", |
There was a problem hiding this comment.
while we're not using react, the airbnb package requires it as a peer dep
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
| - Do not scale product thumbnail images [#1094](https://github.com/bigcommerce/cornerstone/pull/1094) | |||
| - Lazy load carousel images [#1090](https://github.com/bigcommerce/cornerstone/pull/1090) | |||
| - Theme Editor menu item updates for ease of use [#1091] (https://github.com/bigcommerce/cornerstone/pull/1091) | |||
| - Upgrades all dependencies except for Foundation and jQuery [#1069](https://github.com/bigcommerce/cornerstone/pull/1069) | |||
There was a problem hiding this comment.
@mjschock can you fix the line above & remove the space between [#1091] (https://github.com/bigcommerce/cornerstone/pull/1091) 🙏
| "lazysizes": "3.0.0", | ||
| "lodash": "^4.17.4", | ||
| "nod-validate": "^2.0.12", | ||
| "pace": "hubspot/pace#a03f1f1de62c9cea6c88b2267b8d7a83858b6cb6", |
There was a problem hiding this comment.
Do we know why pace is locked down to a commit & not to an actual release ?
There was a problem hiding this comment.
@junedkazi IIRC it's because they made a breaking change. i'll do a quick check to see if we can update now
There was a problem hiding this comment.
yup, there's a breaking change. let's just create a separate PR with the fix
|
@junedkazi regarding the icon-defs, yeah i believe it should change this time since grunt-svgstore has been updated. i just checked out the version from master and ran grunt and it gets updated |
What?
Tickets / Documentation
cc @bigcommerce/stencil-team