Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout.html changes work in development but have no effect in production #1909

Closed
flyingL123 opened this issue Nov 20, 2020 · 5 comments
Closed

Comments

@flyingL123
Copy link
Contributor

Expected behavior

If I make a change in templates/pages/checkout.html file, I am able to see it as expected when running my theme locally with stencil.

Actual behavior

After deploying the theme to the live store, I see the single-page optimized checkout as expected, but the change I made is not present.

Steps to reproduce behavior

In the checkout.html file, I add the highlighted line:
image

View the checkout locally and that new line is visible in the source:

image

Deploy the checkout to the live website, and the new line is not there:

image

Is there something that would cause these changes to not appear on the live site? My store is set to use "Optimized One-Page Checkout". This method of customizing has been working for me for a while. Did something change that would cause this not to work or is there a bug of some kind?

@junedkazi
Copy link
Contributor

@flyingL123 can you confirm you have this added to your features list in the config json
https://github.com/bigcommerce/cornerstone/blob/master/config.json#L34

@flyingL123
Copy link
Contributor Author

flyingL123 commented Nov 20, 2020

@junedkazi 😃 - I was literally just writing a comment that I finally figured it out, and it has to do with that customized_checkout being included in the feature list.

I am surprised to discover that. I thought those features were just used for displaying features on the theme's marketplace page. I didn't realize they actually effected functionality. Is that the intended behavior?

It's particularly confusing because it only effects the theme in production. Thanks very much for getting back to me about this.

@junedkazi
Copy link
Contributor

@flyingL123 it is used for both purposes. In some cases we use it to understand if the theme supports a feature as well which is why we only allow predefined set of keys only rather than free form text.

In case of checkout if the flag exists and if the template file exist it will use the template to render the page or else gracefully fallback to BC default template.

I agree in cases where flags are used to drive theme behavior we need checks in place on stencil cli to warn theme developers. I will create a task internally for the team to look into.

@flyingL123
Copy link
Contributor Author

@junedkazi thanks again!

@junedkazi
Copy link
Contributor

Happy to help. I am closing this since this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants