Merge pull request #1719 from yurytut1993/BCTHEME-45

feature(bctheme): BCTHEME-45 Update CornerStone to Utilize Existence of sale_price property for Determining Product/Variant Sale Status
bigcommerce · Jul 13, 2020 · cf949a5 · cf949a5
2 parents 49f53f1 + e05dfcb
commit cf949a5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/templates/components/amp/products/card.html b/templates/components/amp/products/card.html
@@ -1,6 +1,6 @@
 <article class="card {{#if alternate}}card--alternate{{/if}}">
     <figure class="card-figure">
-        {{#or price.non_sale_price_with_tax price.non_sale_price_without_tax}}
+        {{#or price.sale_price_with_tax.value price.sale_price_without_tax.value}}
             {{#if theme_settings.product_sale_badges}}
                 <div class="sale-sash">
                     <span class="sale-text">On Sale!</span>

diff --git a/templates/components/products/card.html b/templates/components/products/card.html
@@ -1,6 +1,6 @@
 <article class="card {{#if alternate}}card--alternate{{/if}}" {{#if settings.data_tag_enabled}} data-event-type="{{event}}" data-entity-id="{{id}}" data-position="{{position}}" data-name="{{name}}" data-product-category="{{#each category}}{{#if @last}}{{this}}{{else}}{{this}}, {{/if}}{{/each}}" data-product-brand="{{brand.name}}" data-product-price="{{#if price.with_tax}}{{price.with_tax.value}}{{else}}{{price.without_tax.value}}{{/if}}"  {{/if}}>
     <figure class="card-figure">
-        {{#or price.non_sale_price_with_tax price.non_sale_price_without_tax}}
+        {{#or price.sale_price_with_tax.value price.sale_price_without_tax.value}}
             {{#if theme_settings.product_sale_badges '===' 'sash'}}
                 <div class="sale-flag-sash">
                     <span class="sale-text">On Sale!</span>

diff --git a/templates/components/products/list-item.html b/templates/components/products/list-item.html
@@ -4,21 +4,21 @@
     <article class="listItem">
 {{/if}}
     <figure class="listItem-figure">
-        {{#or price.non_sale_price_with_tax price.non_sale_price_without_tax}}
-        {{#if theme_settings.product_sale_badges '===' 'sash'}}
-            <div class="sale-flag-sash">
-                <span class="sale-text">On Sale!</span>
-            </div>
-        {{else if theme_settings.product_sale_badges '===' 'topleft'}}
-            <div class="sale-flag-side">
-                <span class="sale-text">On Sale!</span>
-            </div>
-        {{else if theme_settings.product_sale_badges '===' 'burst'}}
-            <div class="starwrap">
-                <div class="sale-text-burst">On Sale!</div>
-                <div class="sale-flag-star"></div>
-            </div>
-        {{/if}}
+        {{#or price.sale_price_with_tax.value price.sale_price_without_tax.value}}
+            {{#if theme_settings.product_sale_badges '===' 'sash'}}
+                <div class="sale-flag-sash">
+                    <span class="sale-text">On Sale!</span>
+                </div>
+            {{else if theme_settings.product_sale_badges '===' 'topleft'}}
+                <div class="sale-flag-side">
+                    <span class="sale-text">On Sale!</span>
+                </div>
+            {{else if theme_settings.product_sale_badges '===' 'burst'}}
+                <div class="starwrap">
+                    <div class="sale-text-burst">On Sale!</div>
+                    <div class="sale-flag-star"></div>
+                </div>
+            {{/if}}
         {{/or}}    
         {{> components/common/responsive-img
             image=image