fix(storefront): BCTHEME-514 Translation Gap: Gift Certificate -> Cod…

…e required message
bigcommerce · May 19, 2021 · ad7c7e2 · ad7c7e2
1 parent f92352c
commit ad7c7e2
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 10 deletions.
diff --git a/assets/js/theme/cart.js b/assets/js/theme/cart.js
@@ -1,6 +1,7 @@
 import PageManager from './page-manager';
 import { bind, debounce } from 'lodash';
-import giftCertCheck from './common/gift-certificate-validator';
+import checkIsGiftCertValid from './common/gift-certificate-validator';
+import { createTranslationDictionary } from './common/utils/translations-utils';
 import utils from '@bigcommerce/stencil-utils';
 import ShippingEstimator from './cart/shipping-estimator';
 import { defaultModal } from './global/modal';
@@ -363,9 +364,10 @@ export default class Cart extends PageManager {
 
             event.preventDefault();
 
-            if (!giftCertCheck(code)) {
+            if (!checkIsGiftCertValid(code)) {
+                const validationDictionary = createTranslationDictionary(this.context);
                 return swal.fire({
-                    text: $certInput.data('error'),
+                    text: validationDictionary.invalid_gift_certificate,
                     icon: 'error',
                 });
             }

diff --git a/assets/js/theme/common/gift-certificate-validator.js b/assets/js/theme/common/gift-certificate-validator.js
@@ -1,5 +1,5 @@
 export default function (cert) {
-    if (typeof cert !== 'string') {
+    if (typeof cert !== 'string' || cert.length === 0) {
         return false;
     }
 

diff --git a/assets/js/theme/gift-certificate.js b/assets/js/theme/gift-certificate.js
@@ -1,6 +1,6 @@
 import PageManager from './page-manager';
 import nod from './common/nod';
-import giftCertChecker from './common/gift-certificate-validator';
+import checkIsGiftCertValid from './common/gift-certificate-validator';
 import formModel from './common/models/forms';
 import { createTranslationDictionary } from './common/utils/translations-utils';
 import { announceInputErrorMessage } from './common/utils/form-utils';
@@ -204,9 +204,9 @@ export default class GiftCertificate extends PageManager {
         balanceValidator.add({
             selector: $balanceForm.find('input[name="giftcertificatecode"]'),
             validate(cb, val) {
-                cb(giftCertChecker(val));
+                cb(checkIsGiftCertValid(val));
             },
-            errorMessage: 'You must enter a certificate code.',
+            errorMessage: this.validationDictionary.invalid_gift_certificate,
         });
 
         return balanceValidator;

diff --git a/lang/en.json b/lang/en.json
@@ -923,7 +923,8 @@
         "price_max_evaluation": "Min. price must be less than max. price.",
         "price_min_not_entered": "Min. price is required.",
         "price_max_not_entered": "Max. price is required.",
-        "price_invalid_value": "Input must be greater than 0."
+        "price_invalid_value": "Input must be greater than 0.",
+        "invalid_gift_certificate": "Please enter your valid certificate code."
     },
     "validation_fallback_messages": {
         "valid_email": "You must enter a valid email.",
@@ -937,7 +938,8 @@
         "price_max_evaluation": "Min. price must be less than max. price.",
         "price_min_not_entered": "Min. price is required.",
         "price_max_not_entered": "Max. price is required.",
-        "price_invalid_value": "Input must be greater than 0."
+        "price_invalid_value": "Input must be greater than 0.",
+        "invalid_gift_certificate": "Please enter your valid certificate code."
     },
     "validation_default_messages": {
         "valid_email": "You must enter a valid email.",
@@ -951,6 +953,7 @@
         "price_max_evaluation": "Min. price must be less than max. price.",
         "price_min_not_entered": "Min. price is required.",
         "price_max_not_entered": "Max. price is required.",
-        "price_invalid_value": "Input must be greater than 0."
+        "price_invalid_value": "Input must be greater than 0.",
+        "invalid_gift_certificate": "Please enter your valid certificate code."
     }
 }