BCTHEME-210 Carousel hidden when one or more of its images not found

bigcommerce · Sep 11, 2020 · 84f962f · 84f962f
1 parent cea4c32
commit 84f962f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Carousel hidden when one or more of its images not found. [#1816](https://github.com/bigcommerce/cornerstone/pull/1816)
 - Review link in quick modal focused twice. [#1797](https://github.com/bigcommerce/cornerstone/pull/1797)
 - Fixed product image doesn't change on click when viewing a product with multiple images in IE11 [#1748](https://github.com/bigcommerce/cornerstone/pull/1748)
 - Fixed alt text on image change in product view [#1747](https://github.com/bigcommerce/cornerstone/pull/1747)

diff --git a/assets/js/theme/common/carousel.js b/assets/js/theme/common/carousel.js
@@ -108,6 +108,9 @@ export default function () {
                     }
                 });
 
+                showCarouselIfSlidesAnalized($element);
+            })
+            .error(() => {
                 showCarouselIfSlidesAnalized($element);
             });
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -108,6 +108,9 @@ export default function () { @@
                         }
                     });
+                    showCarouselIfSlidesAnalized($element);
+                })
+                .error(() => {
                     showCarouselIfSlidesAnalized($element);
                 });
         });
@@ Expand Down @@