Skip to content

Commit

Permalink
fix(storefront): BCTHEME-398 Make every product option group id unique (
Browse files Browse the repository at this point in the history
  • Loading branch information
BC-tymurbiedukhin authored Feb 9, 2021
1 parent 851e42b commit 3ded830
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Changelog

- Fixed required checkbox message displaying. [1963](https://github.com/bigcommerce/cornerstone/pull/1963)

## Draft
- Make every product option group id unique. [#1979](https://github.com/bigcommerce/cornerstone/pull/1979)
- Fixed required checkbox message displaying. [1963](https://github.com/bigcommerce/cornerstone/pull/1963)
- Provided sufficient & informative text along with the color swatches [#1976](https://github.com/bigcommerce/cornerstone/pull/1976)
- If multiple Pick List Options are applied, customers cannot select "none" on both. [#1975](https://github.com/bigcommerce/cornerstone/pull/1975)
- Moved phrase from compare.html to en.json for increasing localization. [#1972](https://github.com/bigcommerce/cornerstone/pull/1972)
Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/options/set-radio.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="form-field" data-product-attribute="set-radio" role="radiogroup" aria-labelledby="radio-group-label">
<label class="form-label form-label--alternate form-label--inlineSmall" id="radio-group-label">
<div class="form-field" data-product-attribute="set-radio" role="radiogroup" aria-labelledby="radio-group-label-{{id}}">
<label class="form-label form-label--alternate form-label--inlineSmall" id="radio-group-label-{{id}}">
{{ this.display_name }}:

{{> components/common/requireness-msg}}
Expand Down

0 comments on commit 3ded830

Please sign in to comment.