fix(storefront): BCTHEME-153 Insufficient link text

bigcommerce · Aug 13, 2020 · 1d0061f · 1d0061f
1 parent 353c9c8
commit 1d0061f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Fixed Shop by price insufficient link text. [#1786](https://github.com/bigcommerce/cornerstone/pull/1786)
 
 ## 4.9.0 (08-05-2020)
 

diff --git a/lang/en.json b/lang/en.json
@@ -211,6 +211,7 @@
     "category": {
         "label": "Categories",
         "shop_by_price": "Shop By Price",
+        "shop_by_price_range_aria": "Price range from {from} to {to}",
         "reset": "Reset",
         "view_all": {
             "name": "All {category}"

diff --git a/templates/components/category/shop-by-price.html b/templates/components/category/shop-by-price.html
@@ -4,7 +4,14 @@ <h5 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h5>
         <ul class="navList">
             {{#each shop_by_price}}
             <li class="navList-item">
-                <a class="navList-action {{#if selected }} is-active {{/if}}" href="{{url}}" alt="{{low.formatted}} - {{high.formatted}}" title="{{low.formatted}} - {{high.formatted}}">{{low.formatted}} - {{high.formatted}}</a>
+                <a class="navList-action
+                   {{#if selected }} is-active {{/if}}"
+                   href="{{url}}"
+                   title="{{low.formatted}} - {{high.formatted}}"
+                   aria-label="{{{lang 'category.shop_by_price_range_aria' from=low.formatted to=high.formatted}}}"
+                >
+                    {{low.formatted}} - {{high.formatted}}
+                </a>
             </li>
             {{/each}}
 

diff --git a/templates/components/category/sidebar.html b/templates/components/category/sidebar.html
@@ -5,7 +5,7 @@ <h5 class="sidebarBlock-heading">{{category.name}}</h5>
             <ul class="navList">
                 {{#each category.subcategories}}
                 <li class="navList-item">
-                    <a class="navList-action" href="{{url}}" alt="{{name}}" title="{{name}}">{{name}}</a>
+                    <a class="navList-action" href="{{url}}" title="{{name}}">{{name}}</a>
                 </li>
                 {{/each}}
             </ul>