feat(catalog): CATALOG-2406 Add changelog for the ticket. Adding the …

…price_ prefix for was and now to implement PR comments.
bigcommerce · Mar 27, 2018 · 0d9fb8d · 0d9fb8d
1 parent 83b2f8b
commit 0d9fb8d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Add representation for products and variants with retail price that has sale price. [#1195](https://github.com/bigcommerce/cornerstone/pull/1195) 
 - Fix image dimensions on AMP pages. [#1192](https://github.com/bigcommerce/cornerstone/pull/1192)
 - Remove AMP quick-search. [#1191](https://github.com/bigcommerce/cornerstone/pull/1191)
 

diff --git a/lang/en.json b/lang/en.json
@@ -675,8 +675,8 @@
         "select_one": "Please select one",
         "description": "Description",
         "retail_price": "MSRP:",
-        "was": "Was:",
-        "now": "Now:",
+        "price_was": "Was:",
+        "price_now": "Now:",
         "price_with_tax": "(Inc. {tax_label})",
         "price_without_tax": "(Ex. {tax_label})",
         "including_tax": "Including Tax",

diff --git a/templates/components/products/price.html b/templates/components/products/price.html
@@ -10,13 +10,13 @@
         </div>
         <div class="price-section price-section--withTax" {{#if schema_org}}itemprop="offers" itemscope itemtype="http://schema.org/Offer"{{/if}}>
             {{#if price.non_sale_price_with_tax}}
-                {{lang 'products.was'}}
+                {{lang 'products.price_was'}}
                 <span data-product-non-sale-price-with-tax class="price price--rrp"> {{price.non_sale_price_with_tax.formatted}}</span>
             {{/if}}
         </div>
         <div>
             {{#if price.non_sale_price_with_tax}}
-                {{lang 'products.now'}}
+                {{lang 'products.price_now'}}
             {{/if}}
             <span data-product-price-with-tax class="price"> {{price.with_tax.formatted}}</span>
             {{#if schema_org}}
@@ -42,13 +42,13 @@
         </div>
         <div class="price-section price-section--withoutTax {{#if price.with_tax}}price-section--minor{{/if}}"  {{#if schema_org}}itemprop="offers" itemscope itemtype="http://schema.org/Offer"{{/if}}>
             {{#if price.non_sale_price_without_tax}}
-                {{lang 'products.was'}}
+                {{lang 'products.price_was'}}
                 <span data-product-non-sale-price-without-tax class="price price--rrp"> {{price.non_sale_price_without_tax.formatted}}</span>
             {{/if}}
         </div>
         <div>
             {{#if price.non_sale_price_without_tax}}
-                {{lang 'products.now'}}
+                {{lang 'products.price_now'}}
             {{/if}}
             <span data-product-price-without-tax class="price price--withoutTax"> {{price.without_tax.formatted}}</span>
             {{#if schema_org}}