Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new exception for MongoDB Authentication errors #1357

Conversation

lavinasachdev3
Copy link
Contributor

Fixes issue #1336

Have used 'Authentication fail' as the comparison string for authentication failure so that we are able to handle both 'Authentication failed' and 'Authentication failure' error messages.
Also, was thinking of comparing the strings ignoring the case so that if mongo changes their return text to Authentication Fail, it still works. Should we do that or does it seem unnecessary?

@codecov-io
Copy link

codecov-io commented Mar 29, 2017

Codecov Report

Merging #1357 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
- Coverage   98.19%   98.16%   -0.04%     
==========================================
  Files          54       54              
  Lines        2444     2447       +3     
==========================================
+ Hits         2400     2402       +2     
- Misses         44       45       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6de90f...9c4b284. Read the comment docs.

@ttmc
Copy link
Contributor

ttmc commented Apr 1, 2017

Hi @lavinasachdev3,

(Sorry I didn't post this message earlier. I usually do so quicker, but I was away on vacation last week and didn't notice your two recent pull requests until now.)

Before we can merge this pull request, we need you or your organization to agree to one of our contributor agreements. One of the big concerns for people using and developing open source software is that someone who contributed to the code might claim the code infringes on their copyright or patent. To guard against this, we ask all our contributors to sign a Contributor License Agreement. This gives us the right to use the code contributed and any patents the contribution relies on. It also gives us and our users comfort that they won't be sued for using open source software. We know it's a hassle, but it makes the project more reliable in the long run. Thank you for your understanding and your contribution!

If you are contributing on behalf of yourself (and not on behalf of your employer or another organization you are part of) then you should:

  1. Go to: https://www.bigchaindb.com/cla/
  2. Read the Individual Contributor Agreement
  3. Fill in the form "For Individuals"
  4. Check the box to agree
  5. Click the SEND button

If you're contributing as an employee, and/or you want all employees of your employing organization to be covered by our contributor agreement, then someone in your organization with the authority to enter agreements on behalf of all employees must do the following:

  1. Go to: https://www.bigchaindb.com/cla/
  2. Read the Entity Contributor Agreement
  3. Fill in the form "For Organizations”
  4. Check the box to agree
  5. Click the SEND button

We will email you (or your employer) with further instructions.

@lavinasachdev3
Copy link
Contributor Author

Sent the agreement.

@lavinasachdev3
Copy link
Contributor Author

This is to confirm that I agreed to and accepted the BigchainDB Individual Contributor Agreement at https://www.bigchaindb.com/cla/ and to represent and warrant that I have authority to do so.

CuQ2H2InIi8OlYnbBMBlRM0XXOza2RcPcAoRwFbCM47zDUvAVhXmrKhg5GGAz3u

@ttmc
Copy link
Contributor

ttmc commented Apr 1, 2017

Great, thanks @lavinasachdev3

The CLA hurdle is cleared.

@vrde
Copy link
Contributor

vrde commented Apr 10, 2017

Hi @lavinasachdev3, thanks for your PR 🎉

It looks good but, after discussing with the MongoDB folks, I'm undecided if the approach I suggested in #1336 is enough.

I'll wait to know the answer to my question on their issue tracker to decide how to proceed with this PR.

@r-marques
Copy link
Contributor

If after clarifying with the mongodb folks we think that this should go through this pr should add a unit test to test this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants