Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: currency formatting and fixes test spec #7

Merged
merged 8 commits into from
Jan 20, 2024
Merged

fix: currency formatting and fixes test spec #7

merged 8 commits into from
Jan 20, 2024

Conversation

tmchow
Copy link
Contributor

@tmchow tmchow commented Jan 19, 2024 •
edited
Loading

  • refactored test spec to make it easier to add additional future currencies
  • fixed various currency formatting issues
  • Rspec fixed by @paulfri

@tmchow tmchow requested review from outerim and paulfri January 19, 2024 03:48
@tmchow tmchow force-pushed the trevin/chore_improve_test_spec branch from d697d3f to c6d50d1 Compare January 19, 2024 20:14
@tmchow tmchow force-pushed the trevin/chore_improve_test_spec branch from c6d50d1 to e9c7512 Compare January 19, 2024 20:26
@tmchow tmchow changed the title chore: make it easier to add more currencies to test spec fix: currency formatting and fixes test spec Jan 19, 2024
@tmchow tmchow merged commit 88b5181 into master Jan 20, 2024
8 checks passed
@tmchow tmchow deleted the trevin/chore_improve_test_spec branch January 20, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outerim outerim Awaiting requested review from outerim

@paulfri paulfri Awaiting requested review from paulfri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmchow @paulfri