handle the stop codons, COSMIC errors download, ENSEMBL releases #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ypriverol
commented
Jan 26, 2021
•
- handle the stop codons in ensembl databases
- add new test for stop codons.
- Cosmic error handling when the user can't log in.
- Ensembl release issue Ensembl release #23
- Add changelog.md to the project
- Add code quality service.
…op codons character *
|
@husensofteng do not merge yet the PR, still fixing COSMIC login error |
Closed
3 tasks
|
@husensofteng the ensembl grch37 is implemented. Please Review the present PR. |
This was
linked to
issues
Jan 26, 2021
Squashed commits: [c9fdd9a] code clean step [78d4e5d] code clean step [a31dc39] code clean step [7895bd8] code clean step [48ab4e7] change command config path [de40c74] change command config path [3a2da7b] still there [376790e] minor examples [fa84cdf] change command config path [5effa00] change command config path [010fbce] coverage updated [2917989] change command config path [e772df8] added unit tests [c9dfe7d] code coverage
|
@husensofteng the PR is now to be reviewed. |
4 tasks
husensofteng
reviewed
Feb 3, 2021
| @click.option('--config_file', '-c', help='Configuration to perform conversion between ENSEMBL Files', | ||
| default= this_dir + '../config/ensembl_config.yaml') | ||
| @click.option('-c', '--config_file', help='Configuration to perform conversion between ENSEMBL Files', | ||
| default= this_dir + '/../config/ensembl_config.yaml') |
There was a problem hiding this comment.
using this_dir makes issues when the default is used. why not just the default config file without this_dir?
husensofteng
reviewed
Feb 3, 2021
husensofteng
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.