Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable custom codespell dictionary + fix a few fresh typos now detected #1400

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented Feb 6, 2023

The problem is described in:

... maybe we will get some answer soon and before merge of this PR ;)

@sappelhoff
Copy link
Member

converting a draft, as a fix is in the works at codespell-project/codespell#2767

I'll push the two typo corrections directly to master.

098b88e

@sappelhoff sappelhoff marked this pull request as draft March 30, 2023 13:35
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic marked this pull request as ready for review March 31, 2023 13:37
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (098b88e) 87.90% compared to head (7b37a57) 87.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1400   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          14       14           
  Lines        1273     1273           
=======================================
  Hits         1119     1119           
  Misses        154      154           
Impacted Files Coverage Δ
tools/schemacode/bidsschematools/validator.py 84.18% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Collaborator Author

I rebased and refreshed (reapplied codespell since conflicts start piling up) the PR.
I think we better merge it in this shape first to avoid penetration of new typos at a smaller cost of ignoring some custom remappings ATM provided in that dictionary. Whenever codespell-project/codespell#2767 is released - we could just specify it back in config, or whenever action exposes -D option (codespell-project/actions-codespell#62) we could provide second github action step to run in addition with that dictionary.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem correct.

@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Mar 31, 2023
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sappelhoff sappelhoff merged commit 777e864 into bids-standard:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants