Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Service account sidenav type #9

Merged
merged 4 commits into from
Jul 21, 2019

Conversation

bhardwajaditya
Copy link
Owner

A new property sa: true is added to subscription when a user clicks on the directory listing of service account. This property is used to list them separately in the sidenav.

service-account-sidenav

Copy link
Collaborator

@kb0304 kb0304 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code, assuming the functionality is working properly when tested via UI, please go ahead and merge.

@bhardwajaditya bhardwajaditya merged commit 1d57519 into service-accounts Jul 21, 2019
@bhardwajaditya bhardwajaditya deleted the service-account-sidenav branch July 21, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants