adding tests and comments

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
bharath-techie · May 11, 2022 · 04532f4 · 04532f4
1 parent 480bdc2
commit 04532f4
Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/server/src/main/java/org/opensearch/action/search/DeletePitAction.java b/server/src/main/java/org/opensearch/action/search/DeletePitAction.java
@@ -16,7 +16,7 @@
 public class DeletePitAction extends ActionType<DeletePitResponse> {
 
     public static final DeletePitAction INSTANCE = new DeletePitAction();
-    public static final String NAME = "indices:admin/delete/pit";
+    public static final String NAME = "indices:admin/read/pit/delete";
 
     private DeletePitAction() {
         super(NAME, DeletePitResponse::new);

diff --git a/server/src/main/java/org/opensearch/action/search/SearchTransportService.java b/server/src/main/java/org/opensearch/action/search/SearchTransportService.java
@@ -389,6 +389,9 @@ public ShardSearchContextId id() {
 
     }
 
+    /**
+     * Request to free the PIT context based on id
+     */
     static class PitFreeContextRequest extends TransportRequest {
         private ShardSearchContextId contextId;
 

diff --git a/server/src/main/java/org/opensearch/action/search/TransportDeletePitAction.java b/server/src/main/java/org/opensearch/action/search/TransportDeletePitAction.java
@@ -60,6 +60,9 @@ public TransportDeletePitAction(
         this.searchTransportService = searchTransportService;
     }
 
+    /**
+     * Invoke delete all pits or delete list of pits workflow based on request
+     */
     @Override
     protected void doExecute(Task task, DeletePitRequest request, ActionListener<DeletePitResponse> listener) {
         List<SearchContextIdForNode> contexts = new ArrayList<>();
@@ -96,15 +99,17 @@ void deleteAllPits(ActionListener<DeletePitResponse> listener) {
             new ActionListener<>() {
                 @Override
                 public void onResponse(final Collection<SearchTransportService.SearchFreeContextResponse> responses) {
-                    final SetOnce<Boolean> succeeded = new SetOnce<>();
-                    for (SearchTransportService.SearchFreeContextResponse response : responses) {
-                        if (!response.isFreed()) {
-                            succeeded.set(false);
-                            break;
-                        }
-                    }
-                    succeeded.trySet(true);
-                    listener.onResponse(new DeletePitResponse(succeeded.get()));
+                    //final SetOnce<Boolean> succeeded = new SetOnce<>();
+                    boolean hasFailures = responses.stream().anyMatch(r-> !r.isFreed());
+                    listener.onResponse(new DeletePitResponse(!hasFailures));
+//                    for (SearchTransportService.SearchFreeContextResponse response : responses) {
+//                        if (!response.isFreed()) {
+//                            succeeded.set(false);
+//                            break;
+//                        }
+//                    }
+//                    succeeded.trySet(true);
+//                    listener.onResponse(new DeletePitResponse(succeeded.get()));
                 }
 
                 @Override