Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'hideAfterPaletteSelect' option. #238

Merged
merged 1 commit into from
Jul 30, 2014
Merged

Added 'hideAfterPaletteSelect' option. #238

merged 1 commit into from
Jul 30, 2014

Conversation

Partyschaum
Copy link
Contributor

In order to simply switch between more palette presets the
'hidePaletteAfterSelect' options was added to optionally prevent the
palette from closing after one preset was selected.

In order to simply switch between more palette presets the
'hidePaletteAfterSelect' options was added to optionally prevent the
palette from closing after one preset was selected.
@joscha
Copy link

joscha commented Jul 30, 2014

👍

@bgrins
Copy link
Owner

bgrins commented Jul 30, 2014

Looks nice :). I wonder if this should be the default actually, since choosing a color via dragging or typing a color in the input doesn't hide the picker. I'll check it out

@bgrins bgrins changed the title Added 'hidePaletteAfterSelect' option. Added 'hideAfterPaletteSelect' option. Jul 30, 2014
@bgrins bgrins merged commit 4f2c0f0 into bgrins:master Jul 30, 2014
@bgrins
Copy link
Owner

bgrins commented Jul 30, 2014

Renamed to hideAfterPaletteSelect and landed to master

@joscha
Copy link

joscha commented Jul 30, 2014

@bgrins nice! Do you know already when you are planning the next release? We'd love to pick this up in Jimdo/angular-spectrum-colorpicker.

@bgrins
Copy link
Owner

bgrins commented Jul 30, 2014

Don't have anything in particular planned... I usually check 1.4.1...master and wait for a few things to add up. I'll bump to 1.5 next since this is adding new functionality - let me check some other issues and see if anything else could fit in

@Xiphe
Copy link

Xiphe commented Aug 13, 2014

Would love to see a release including hidePaletteAfterSelect soon.

@bgrins
Copy link
Owner

bgrins commented Aug 14, 2014

Would love to see a release including hidePaletteAfterSelect soon.

Done: https://github.com/bgrins/spectrum/releases/tag/1.5.0

@Xiphe
Copy link

Xiphe commented Aug 15, 2014

brilliant!

@Partyschaum Partyschaum deleted the do-not-hide-palette-after-select branch August 17, 2014 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants