-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid hue - no slider #93
Comments
Can you please make a test case showing the problem? You can fork this jsFiddle: http://jsfiddle.net/bgrins/ctkY3/. I'm not sure how the hue is becoming invalid in the first place. |
http://jsfiddle.net/ctkY3/748/ red works, because even if hue was multiplied by Infinity, it's still 0, so it's ok |
@zb3 thanks! This should now be fixed on: http://jsfiddle.net/ctkY3/749/. I will take care of a couple of other issues then tag a new release, but it is fixed in master. |
in function set, line 533:
currentHue = newHsv.h;
but the problem is that we expect currentHue to be in this range: <0, 1>
so actually there should be:
currentHue = newHsv.h/360;
then slider works, but I don't know if this patch doesn't break other stuff
The text was updated successfully, but these errors were encountered: