Implement topology utils methods #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12ef736 to
4cf0576
Compare
guissalustiano
commented
Jan 17, 2024
Comment on lines
+626
to
+636
| #[test] | ||
| #[ignore] | ||
| fn test_path_graph_never_generate_ciclic() { | ||
| let topo = Topology::from_caida(get_caida_data()).unwrap(); | ||
|
|
||
| topo.all_asns().into_par_iter().for_each(|asn| { | ||
| let topo = topo.paths_graph(asn); | ||
| assert!(!is_cyclic_directed(&topo.graph)); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
It is a very heavy test, I ran this locally for 1hour and didn't find any cycle.
I'm not sure if it is working to keep this here, but maybe could be useful in the future
|
I see that you are still pushing new commits to the PRs. Let me know if they're ready for review. Thanks! |
|
Hey @digizeph |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here. This PR creates methods to analyze the graph.
This is the naive implementation based on the examples folder.
I didn't like this implementation because for this method you always need the run the
paths_graphbefore, maybe we can create another typeValleyFreeTopologythat has the guarantee that is a DAG, only been generated by thepaths_graphand already having the source is inside of them, what do you think?I also found a bug in the
paths_graphimplementation in the test for the other methods that I will solve here.