Improved search/parse filters; support search RIB dump files #70
+441
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `filters` and `time` modules for cleaner separation - Moved `ParseFilters` and `SearchFilters` implementations to `filters` - Centralized time-related logic into the `time.rs` module - Replaced redundant `parser_with_filters` function with traits in `filters` - Simplified dependencies in `monocle.rs` by leveraging modularized functions
- Corrected article usage (e.g., 'a' to 'an') in multiple descriptions. - Added missing commas in example clarifications (e.g., 'e.g., US'). - Improved phrasing for clarity (e.g., 'prefix-to-origin mapping'). - Adjusted minor formatting inconsistencies in comments and annotations.
- updated `parse_start_end_strings` to return `i64` instead of `String`. - replaced `.to_rfc3339()` calls with `.timestamp()`. - adjusted return values to reflect the new timestamp format.
- added `DumpType` enum with options for updates, rib, and both - added `dump_type` field with `updates` as default - updated broker query to filter by selected dump type
|
Nice to see this feature implemented. May I know when are you releasing this feature? I am not into Rust programming. So I just want to use the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the implementation of filters for
monocle parseandmonocle search. It also adds support for searching data from RIB dump files.This PR resolves the following issues: #68
Refactor filters implementation
filtersandtimemodules for cleaner separationParseFiltersandSearchFiltersimplementations tofilterstime.rsmoduleparser_with_filtersfunction with traits infiltersmonocle.rsby leveraging modularized functionsSupport search RIB dump files
--dump_typeargument formonocle searchcommand:updates: default, search updates files onlyrib: search RIB dump files onlyrib-updates: search both RIB dump and updates filesFor example, the following command searches RIB dump files that overlaps with the first hour of 2024 (GMT).