fix: ignore minor gas changes

bgd-labs · Nov 18, 2024 · cdd2cce · cdd2cce
1 parent e70b73e
commit cdd2cce
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 3 deletions.
diff --git a/dist/action.js b/dist/action.js
@@ -23974,6 +23974,7 @@ function findFunction(fn, snapshot) {
 function formatValue(before, after) {
   if (!before || after === before) return after;
   const diff = (after - before) / Math.abs(before) * 100;
+  if (Math.abs(diff) < 0.1) return after;
   return `<sup title="${before}">${diff > 0 ? UP : DOWN}${new Intl.NumberFormat(
     "en-US",
     {

diff --git a/dist/action.mjs b/dist/action.mjs
@@ -23979,6 +23979,7 @@ function findFunction(fn, snapshot) {
 function formatValue(before, after) {
   if (!before || after === before) return after;
   const diff = (after - before) / Math.abs(before) * 100;
+  if (Math.abs(diff) < 0.1) return after;
   return `<sup title="${before}">${diff > 0 ? UP : DOWN}${new Intl.NumberFormat(
     "en-US",
     {

diff --git a/dist/lib.js b/dist/lib.js
@@ -34,6 +34,7 @@ function findFunction(fn, snapshot) {
 function formatValue(before, after) {
   if (!before || after === before) return after;
   const diff = (after - before) / Math.abs(before) * 100;
+  if (Math.abs(diff) < 0.1) return after;
   return `<sup title="${before}">${diff > 0 ? UP : DOWN}${new Intl.NumberFormat(
     "en-US",
     {

diff --git a/dist/lib.mjs b/dist/lib.mjs
@@ -10,6 +10,7 @@ function findFunction(fn, snapshot) {
 function formatValue(before, after) {
   if (!before || after === before) return after;
   const diff = (after - before) / Math.abs(before) * 100;
+  if (Math.abs(diff) < 0.1) return after;
   return `<sup title="${before}">${diff > 0 ? UP : DOWN}${new Intl.NumberFormat(
     "en-US",
     {

diff --git a/mocks/gas.json b/mocks/gas.json
@@ -15,7 +15,7 @@
         "min": 1024,
         "mean": 1024,
         "median": 1024,
-        "max": 1024
+        "max": 1025
       }
     }
   },

diff --git a/src/__snapshots__/lib.spec.ts.snap b/src/__snapshots__/lib.spec.ts.snap
@@ -8,7 +8,7 @@ exports[`lib > should generate a well formatted report with empty root 1`] = `
 | Method | min | mean | median | max | calls |
 | --- | ---: | ---: | ---: | ---: | ---: |
 create(bytes32,bytes) | 286388 | 296666 | 287062 | 397068 | 6 |
-predictAddress(address,bytes32) | 1024 | 1024 | 1024 | 1024 | 6 |
+predictAddress(address,bytes32) | 1024 | 1024 | 1024 | 1025 | 6 |
 
 
 ### [ProxyAdmin](https://github.com/src/contracts/transparent-proxy/ProxyAdmin.sol)
@@ -75,6 +75,7 @@ exports[`lib > should generate a well formatted report with existing root & skip
 | Method | min | mean | median | max | calls |
 | --- | ---: | ---: | ---: | ---: | ---: |
 create(bytes32,bytes) | <sup title="296388">↓-3.4%</sup>286388 | 296666 | 287062 | <sup title="297068">↑34%</sup>397068 | 6 |
+predictAddress(address,bytes32) | 1024 | 1024 | 1024 | 1025 | 6 |
 
 
 ### [TransparentProxyFactory](https://github.com/src/contracts/transparent-proxy/TransparentProxyFactory.sol)
@@ -92,7 +93,7 @@ exports[`lib > should generate a well formatted report with existing root 1`] =
 | Method | min | mean | median | max | calls |
 | --- | ---: | ---: | ---: | ---: | ---: |
 create(bytes32,bytes) | <sup title="296388">↓-3.4%</sup>286388 | 296666 | 287062 | <sup title="297068">↑34%</sup>397068 | 6 |
-predictAddress(address,bytes32) | 1024 | 1024 | 1024 | 1024 | 6 |
+predictAddress(address,bytes32) | 1024 | 1024 | 1024 | 1025 | 6 |
 
 
 ### [ProxyAdmin](https://github.com/src/contracts/transparent-proxy/ProxyAdmin.sol)

diff --git a/src/lib.ts b/src/lib.ts
@@ -47,6 +47,8 @@ function findFunction(
 function formatValue(before: number | undefined, after: number) {
   if (!before || after === before) return after;
   const diff = ((after - before) / Math.abs(before)) * 100;
+  // if diff is below threshold, showing the diff is more noise than signal
+  if (Math.abs(diff) < 0.1) return after;
   return `<sup title="${before}">${diff > 0 ? UP : DOWN}${new Intl.NumberFormat(
     "en-US",
     {