Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TableWidget getHeading #306

Closed
wants to merge 2 commits into from
Closed

Conversation

noxoua
Copy link
Contributor

@noxoua noxoua commented Jan 5, 2024

the getLocalizedWidgetLabel must call table method in order to get the custom heading.

invade($widgetInstance)->table(invade($widgetInstance)->makeTable())->getHeading()

Custom heading:
Screenshot 2024-01-05 at 14 02 29

Copy link

what-the-diff bot commented Jan 5, 2024

PR Summary

  • Language Translation Updates

    • We updated several labels in the Ukrainian (uk) language file for the Filament Shield system to make them more accurate and intuitive for Ukrainian users.
    • Specifically, we made changes to field names and permission labels used in the system to reflect more meaningful translations in Ukrainian.
  • Widget Labeling Modification

    • We tweaked the method that fetches labels for widgets used in our system.
    • Now, the system first checks if the widget is a TableWidget. If it is, it grabs the table's heading to use as the label.
    • If the widget isn't a TableWidget but does have a getHeading method, it will use the result of this method as the label.
    • If neither condition is met, the system manipulates the widget's name string to derive a suitable label.

These changes aim to improve user experience for our Ukrainian-speaking users and ensure that appropriate labels are provided for different widgets in our platform.

@bezhanSalleh
Copy link
Owner

bezhanSalleh commented Jan 7, 2024

the getLocalizedWidgetLabel must call table method in order to get the custom heading.

invade($widgetInstance)->table(invade($widgetInstance)->makeTable())->getHeading()

Custom heading: Screenshot 2024-01-05 at 14 02 29

the current implementation does account for the given scenario. Unless i'm missing something?
also could you make it clear which lang file is the final one, cause you have a standlone PR for lang and its also updated in this PR. any changes you wanna make for the language push it to the existing PR and remove it from here.

@bezhanSalleh
Copy link
Owner

since a bug had to be fixed and you didn't sort out the issue with lang and didn't respond to the question this will be closed.

@noxoua noxoua deleted the noxoua-patch-1 branch January 15, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants