Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer collect into Vec #11

Merged
merged 1 commit into from
Dec 26, 2024
Merged

prefer collect into Vec #11

merged 1 commit into from
Dec 26, 2024

Conversation

BenjaminBrienen
Copy link
Collaborator

Objective

Idiomatic rust with iterators

Solution

Prefer iter map collect

Part of bevyengine/bevy#15660

@BenjaminBrienen BenjaminBrienen self-assigned this Dec 26, 2024
@BenjaminBrienen BenjaminBrienen added S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Straightforward Simple to understand and implement. A-AllTuples A change to the all_tuples*! macros. C-Code-Quality A section of code that is hard to understand or change, unidiomatic, or triggers a lint. labels Dec 26, 2024
@alice-i-cecile alice-i-cecile merged commit 8da80cc into main Dec 26, 2024
23 of 25 checks passed
@BenjaminBrienen BenjaminBrienen deleted the collect branch December 26, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-AllTuples A change to the all_tuples*! macros. C-Code-Quality A section of code that is hard to understand or change, unidiomatic, or triggers a lint. D-Straightforward Simple to understand and implement. S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminBrienen @alice-i-cecile