make glsl and spirv support optional #8491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
spirv
andglsl
shader format support optional. They are not needed for Bevy shaders.msl
), this reduces the total build time by 2 to 5 seconds, improvement should be even better with less coresThere is a big reduction in compile time for
naga
, and small improvements onwgpu
andbevy_render
This PR with optional shader formats enabled timings:

This PR:

Migration Guide
spirv
, enable theshader_format_spirv
featureglsl
, enable theshader_format_glsl
feature