[Merged by Bors] - AppExit documentation updates (#7067) #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Objective Help users understand how to write code that runs when the app is exiting. See: - bevyengine#7067 (Partial resolution) ## Solution Added documentation to `AppExit` class that mentions using the `Drop` trait for code that needs to run on program exit, as well as linking to the caveat about `App::run()` not being guaranteed to return.
james7132
approved these changes
Jan 23, 2023
mockersf
approved these changes
Jan 23, 2023
Aceeri
approved these changes
Jan 23, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
# Objective Help users understand how to write code that runs when the app is exiting. See: - #7067 (Partial resolution) ## Solution Added documentation to `AppExit` class that mentions using the `Drop` trait for code that needs to run on program exit, as well as linking to the caveat about `App::run()` not being guaranteed to return.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Help users understand how to write code that runs when the app is exiting. See: - bevyengine#7067 (Partial resolution) ## Solution Added documentation to `AppExit` class that mentions using the `Drop` trait for code that needs to run on program exit, as well as linking to the caveat about `App::run()` not being guaranteed to return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Help users understand how to write code that runs when the app is exiting.
See:
Solution
Added documentation to
AppExitclass that mentions using theDroptrait for code that needs to run on program exit, as well as linking to the caveat aboutApp::run()not being guaranteed to return.