Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Change From<Icosphere> to TryFrom<Icosphere> #6484

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Change From<Icosphere> to TryFrom<Icosphere> #6484

wants to merge 3 commits into from

Conversation

2ne1ugly
Copy link
Contributor

@2ne1ugly 2ne1ugly commented Nov 5, 2022 •
edited
Loading

Objective

Solution

  • Return error instead of panic through TryFrom
  • Add .except() in examples
  • Add .unwrap() in examples

TimJentzsch
TimJentzsch approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@alice-i-cecile alice-i-cecile added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Nov 5, 2022
alice-i-cecile
alice-i-cecile requested changes Nov 5, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new error type!

The .expects should be replaced by .unwrap: the error returned will be better than a simple string and it's easier to maintain and read.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Rendering Drawing game state to the screen labels Nov 5, 2022
@2ne1ugly 2ne1ugly changed the title Change From<Icosphere> to TryFrom<Icosphere> Change From<Icosphere> to TryFrom<Icosphere> Nov 5, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 5, 2022
@cart
Copy link
Member

cart commented Nov 14, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 14, 2022
@2ne1ugly
Change From<Icosphere> to TryFrom<Icosphere> (#6484)
db0d769 
# Objective

- Fixes  #6476

## Solution

- Return error instead of panic through `TryFrom`
- ~~Add `.except()` in examples~~ 
- Add `.unwrap()` in examples
@bors
Copy link
Contributor

bors bot commented Nov 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Change From<Icosphere> to TryFrom<Icosphere> [Merged by Bors] - Change From<Icosphere> to TryFrom<Icosphere> Nov 14, 2022
@bors bors bot closed this Nov 14, 2022
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
@2ne1ugly @taiyoungjang
Change From<Icosphere> to TryFrom<Icosphere> (bevyengine#6484)
921a418 
# Objective

- Fixes  bevyengine#6476

## Solution

- Return error instead of panic through `TryFrom`
- ~~Add `.except()` in examples~~ 
- Add `.unwrap()` in examples
@2ne1ugly 2ne1ugly deleted the try-from-icosphere branch January 8, 2023 06:33
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@2ne1ugly @alradish
Change From<Icosphere> to TryFrom<Icosphere> (bevyengine#6484)
69a98ae 
# Objective

- Fixes  bevyengine#6476

## Solution

- Return error instead of panic through `TryFrom`
- ~~Add `.except()` in examples~~ 
- Add `.unwrap()` in examples
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@2ne1ugly @ItsDoot
Change From<Icosphere> to TryFrom<Icosphere> (bevyengine#6484)
0153291 
# Objective

- Fixes  bevyengine#6476

## Solution

- Return error instead of panic through `TryFrom`
- ~~Add `.except()` in examples~~ 
- Add `.unwrap()` in examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV MrGVSV left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile requested changes

@IceSentry IceSentry IceSentry approved these changes

@TimJentzsch TimJentzsch TimJentzsch approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy::fallible-impl-from for From<Icosphere> for Mesh
6 participants
@2ne1ugly @cart @alice-i-cecile @IceSentry @TimJentzsch @MrGVSV