-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test plugin group #5932
Add test plugin group #5932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea, and I agree with this selection.
I would rather have a feature that would enable only what is interesting in CI than a plugin group. The feature would help reducing compile time. |
e0c042c
to
a5412b2
Compare
a5412b2
to
0740263
Compare
Any tests that run can't have |
1172d13
to
9b57fc3
Compare
9b57fc3
to
7db32f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example should live in the root level tests
directory, which will avoid the shenanigans :) We should try and publicize that better though; perhaps we can add a note to the examples README?
b7c6edb
to
f51258c
Compare
Done. There was already how_to_test_systems.rs, but I kept my example because it's much simpler than the other one. |
2f0c2b6
to
d2e056d
Compare
7d89248
to
d448cc8
Compare
@@ -0,0 +1,48 @@ | |||
//! This example illustrates test systems. | |||
fn main() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire main
function shouldn't be necessary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I'm linking to it in the examples page, I wanted to give an informative message to someone who accidentally ran cargo run --example automated_tests
rather than cargo test --example automated_tests
@mockersf I want your opinion on the organization here. I think it's interesting that we're linking to this from the examples README / including it in the cargo.toml. Unsure if it's the right choice! |
One problem with this structure is that it causes cargo to print |
ee830be
to
21fbed7
Compare
21fbed7
to
075ec8e
Compare
075ec8e
to
200587b
Compare
When I test something on CI I add only plugins I need. So I wouldn't add a specific plugin group. |
Closing out; I don't think this is a reliable enough solution to include at the engine level. |
Objective
Work towards closing #5931
Solution
TestPlugins
group that addsMinimalPlugins
,AssetPlugin
,ScenePlugin
,WindowPlugin
,GilrsPlugin
,TransformPlugin
,HierarchyPlugin
,DiagnosticsPlugin
, andInputPlugin
.Limitations
bevy_rapier
will not work as it depends onRenderPlugin
, but this is fixed in Make RenderPlugin emit only a soft error when there's no gpu, instead of panicking #5933.LogPlugin
cannot be added until Avoid unwrap log initialization #4934 is resolvedChangelog
Added
TestPlugins
group that adds plugins suitable for use in automated tests.