Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - remove disable-weak-memory-emulation #5469

Closed
wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Rob Parrett <robparrett@gmail.com>
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

In Miri we trust.

bors bot pushed a commit that referenced this pull request Jul 27, 2022
# Objective

- Fixes #5164
- Remove `miri-disable-weak-memory-emulation`
- Issue has been fixed in dependency
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Feature A new feature, making something new possible labels Jul 27, 2022
@bors bors bot changed the title remove disable-weak-memory-emulation [Merged by Bors] - remove disable-weak-memory-emulation Jul 27, 2022
@bors bors bot closed this Jul 27, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
# Objective

- Fixes bevyengine#5164
- Remove `miri-disable-weak-memory-emulation`
- Issue has been fixed in dependency
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
# Objective

- Fixes bevyengine#5164
- Remove `miri-disable-weak-memory-emulation`
- Issue has been fixed in dependency
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- Fixes bevyengine#5164
- Remove `miri-disable-weak-memory-emulation`
- Issue has been fixed in dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

world::World doctests sometimes hangs with Miri
4 participants