Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix comment typo #5421

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Fix comment typo #5421

wants to merge 6 commits into from

Conversation

eiei114
Copy link
Contributor

@eiei114 eiei114 commented Jul 22, 2022

Objective

  • Fix some typos

Solution

For the first time in my life, I made a pull request to OSS.
Am I right?

rparrett
rparrett suggested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, couple of good catches. I found an additional typo in one of the lines you modified.

But I think a few of the changes aren't necessary.

crates/bevy_gltf/src/lib.rs Outdated Show resolved Hide resolved
crates/bevy_ui/src/focus.rs Outdated Show resolved Hide resolved
crates/bevy_ui/src/focus.rs Outdated Show resolved Hide resolved
crates/bevy_utils/src/lib.rs Outdated Show resolved Hide resolved
@eiei114
Copy link
Contributor Author

eiei114 commented Jul 22, 2022

@rparrett
The problem was that English was not my first language and I did it messily using the editor's proofreading function.

Thank you for the detailed instructions🥰

@alice-i-cecile
Copy link
Member

Agree with the comments from @rparett :) @eiei114, thanks, and welcome to OSS 🎉 On the "Files changed" tab you can commit suggestions directly :)

@eiei114 @rparrett
Update crates/bevy_gltf/src/lib.rs
f8b680e 
Co-authored-by: Rob Parrett <robparrett@gmail.com>
@rparrett
Copy link
Contributor

Oops, I didn't add "github suggestions" for the comments where things were okay as-is. So you'll want to:

  • Pull the suggestion commit that github made in your branch for you to your local branch
  • Make those other changes manually
  • Push the branch back

@alice-i-cecile
Copy link
Member

I've added suggestions for those reversions now, in case that's easier for you :) You can "add suggestions to batch", and get a slightly nicer commit history too. It's not a big deal here though, this is a tiny PR and we squash commits on merge.

eiei114 and others added 3 commits July 22, 2022 23:35
@eiei114 @alice-i-cecile
Update crates/bevy_ui/src/focus.rs
18aba6d 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@eiei114 @alice-i-cecile
Update crates/bevy_ui/src/focus.rs
55505ba 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@eiei114 @alice-i-cecile
Update crates/bevy_utils/src/lib.rs
24d4987 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@eiei114
Copy link
Contributor Author

eiei114 commented Jul 22, 2022

Sorry🤦‍♂️ I forgot that you only raised the suggestion and no changes were made 😂

@alice-i-cecile
Copy link
Member

Looks great! You're now officially a contributor to Bevy ;)

bors r+

@alice-i-cecile alice-i-cecile added the C-Docs An addition or correction to our documentation label Jul 22, 2022
bors bot pushed a commit that referenced this pull request Jul 22, 2022
@eiei114
Fix comment typo (#5421)
619c30c 
# Objective

- Fix some typos

## Solution

For the first time in my life, I made a pull request to OSS.
Am I right?


Co-authored-by: eiei114 <60887155+eiei114@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 22, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix comment typo [Merged by Bors] - Fix comment typo Jul 22, 2022
@bors bors bot closed this Jul 22, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@eiei114 @inodentry
Fix comment typo (bevyengine#5421)
280104a 
# Objective

- Fix some typos

## Solution

For the first time in my life, I made a pull request to OSS.
Am I right?


Co-authored-by: eiei114 <60887155+eiei114@users.noreply.github.com>
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@eiei114 @james7132
Fix comment typo (bevyengine#5421)
d593921 
# Objective

- Fix some typos

## Solution

For the first time in my life, I made a pull request to OSS.
Am I right?


Co-authored-by: eiei114 <60887155+eiei114@users.noreply.github.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@eiei114 @ItsDoot
Fix comment typo (bevyengine#5421)
9488cf8 
# Objective

- Fix some typos

## Solution

For the first time in my life, I made a pull request to OSS.
Am I right?


Co-authored-by: eiei114 <60887155+eiei114@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

@rparrett rparrett rparrett approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eiei114 @alice-i-cecile @rparrett