Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Clean up advice on glob imports in style guide #4644

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Clean up advice on glob imports in style guide #4644

wants to merge 2 commits into from

Conversation

alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented May 2, 2022 •
edited
Loading

Objective

  • Example was misleading, as we never import bevy itself in the engine (except in integration tests).

Solution

  • Clean up wording.

Context

Noticed by @mockersf in #4608.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Meta About the project itself labels May 2, 2022
@alice-i-cecile
Copy link
Member Author

@DJMcNab, this is probably as good of a place as any to chat about the appropriateness of this rule, especially for bevy_ecs::prelude. I'm personally opposed for everything other than the ECS prelude, but would support an exception due to the tedious frustration when defining many systems.

If we want to change it, I can tweak the PR, although that will require @cart sign-off due to its impact on engine-wide style.

@alice-i-cecile alice-i-cecile mentioned this pull request May 2, 2022
Closed
@alice-i-cecile @mockersf
Update .github/contributing/engine_style_guide.md
b1732d9 
Co-authored-by: François <mockersf@gmail.com>
@alice-i-cecile
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request May 2, 2022
@alice-i-cecile
Clean up advice on glob imports in style guide (#4644)
241a61d 
# Objective

- Example was misleading, as we never import `bevy` itself in the engine (except in integration tests).

## Solution

- Clean up wording.

## Context

Noticed by @mockersf in #4608.
@bors
Copy link
Contributor

bors bot commented May 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Clean up advice on glob imports in style guide [Merged by Bors] - Clean up advice on glob imports in style guide May 2, 2022
@bors bors bot closed this May 2, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@alice-i-cecile @exjam
Clean up advice on glob imports in style guide (bevyengine#4644)
d580827 
# Objective

- Example was misleading, as we never import `bevy` itself in the engine (except in integration tests).

## Solution

- Clean up wording.

## Context

Noticed by @mockersf in bevyengine#4608.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@alice-i-cecile @ItsDoot
Clean up advice on glob imports in style guide (bevyengine#4644)
e22c7c9 
# Objective

- Example was misleading, as we never import `bevy` itself in the engine (except in integration tests).

## Solution

- Clean up wording.

## Context

Noticed by @mockersf in bevyengine#4608.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Meta About the project itself C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alice-i-cecile @mockersf