Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - do not check links on docs.github.com #4578

Closed

Conversation

mockersf
Copy link
Member

Objective

  • related to check-markdown-links is painfully flaky #4575, but not a complete fix
  • links to GitHub.com can't be checked from inside a GitHub Actions as GitHub is protecting itself from being flooded by an action execution
  • it seems they added that protection to GitHub doc site

Solution

  • Ignore links to docs.github.com

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 24, 2022
@mockersf mockersf added A-Build-System Related to build systems or continuous integration and removed S-Needs-Triage This issue needs to be labelled labels Apr 24, 2022
@hymm
Copy link
Contributor

hymm commented Apr 24, 2022

why did gamepad_input_events.rs change here?

@mockersf mockersf force-pushed the no-check-for-github-docs-link branch from c43ac44 to a05d341 Compare April 24, 2022 17:54
@mockersf
Copy link
Member Author

mockersf commented Apr 24, 2022

why did gamepad_input_events.rs change here?

because I'm not that good at multitasking... removed! and thanks for noticing

@alice-i-cecile alice-i-cecile added the C-Bug An unexpected or incorrect behavior label Apr 24, 2022
@alice-i-cecile
Copy link
Member

I hate that we have these rules, but it's better than nothing.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 24, 2022
# Objective

- related to #4575, but not a complete fix
- links to GitHub.com can't be checked from inside a GitHub Actions as GitHub is protecting itself from being flooded by an action execution
- it seems they added that protection to GitHub doc site

## Solution

- Ignore links to docs.github.com
@bors bors bot changed the title do not check links on docs.github.com [Merged by Bors] - do not check links on docs.github.com Apr 24, 2022
@bors bors bot closed this Apr 24, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
# Objective

- related to bevyengine#4575, but not a complete fix
- links to GitHub.com can't be checked from inside a GitHub Actions as GitHub is protecting itself from being flooded by an action execution
- it seems they added that protection to GitHub doc site

## Solution

- Ignore links to docs.github.com
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- related to bevyengine#4575, but not a complete fix
- links to GitHub.com can't be checked from inside a GitHub Actions as GitHub is protecting itself from being flooded by an action execution
- it seems they added that protection to GitHub doc site

## Solution

- Ignore links to docs.github.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants