-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows as entities #4531
Windows as entities #4531
Conversation
|
I love the idea behind the PR. I like the code at least. Looking forward to the completion of the PR. Just throwing ideas: What about deriving |
@fowenix for this, I think I would probably just do a struct Resolution {
physical_width: u32,
physical_height: u32,
scale_factor: f64,
} And then move those methods to methods on the new |
Gonna rework this some more and eventually reopen this from another branch instead of main |
Objective
Draft PR of #4530