Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change system name of RunSystem to system type name, not param type name #3935

Closed
wants to merge 1 commit into from
Closed

change system name of RunSystem to system type name, not param type name #3935

wants to merge 1 commit into from

Conversation

jakobhellermann
Copy link
Contributor

Tools like bevy_mod_debugdump use the system name to visualize the schedule.

Previously, the system name of RunSystems would have the type name of their system param as their system name, so for example the PrepareAssetSystem<StandardMaterial> was called (ResMut<ExtractedAssets<StandardMaterial>>, ResMut<HashMap<Handle<StandardMaterial>, GpuStandardMaterial, RandomState>>, ResMut<PrepareNextFrameAssets<StandardMaterial>>, (Res<RenderDevice>, Res<MaterialPipeline<StandardMaterial>>, Res<HashMap<Handle<Image>, GpuImage, RandomState>>)).

This PR uses the name of the type implementing RunSystem as system name, so the new name is PrepareAssetSystem<StandardMaterial>.


Before:
prepare schedule before
After:
prepare schedule after

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 13, 2022
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Feb 13, 2022
alice-i-cecile
alice-i-cecile approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-motivated, code checks out. I like this.

DJMcNab
DJMcNab approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3817 proposes to remove RunSystem.

That being said, this change is an improvement, if we do keep it.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 14, 2022
@mockersf
Copy link
Member

mockersf commented Mar 5, 2022

#3817 proposes to remove RunSystem.

What would the span looks like without the RunSystem?

@DJMcNab
Copy link
Member

DJMcNab commented Mar 5, 2022

Whatever the span looks like with a function system, which I don't have to hand?

@jakobhellermann
Copy link
Contributor Author

Since #3817 is now merged, this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobhellermann @mockersf @DJMcNab @alice-i-cecile