Fix validation errors in Fox.glb
#17801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix gltf validation errors in
Fox.glb
.Inspired by #8099, but that issue doesn't appear to describe a real bug to fix, as far as I can tell.
Solution
Use the latest version of the Fox from glTF-Sample-Assets.
Testing
Dropped both versions in https://github.khronos.org/glTF-Validator/
cargo run --example animated_mesh
seems to still look fine.Before:
After:
Discussion
The 3d testbed was panicking with
Which is bizarre. I think this might be related to #17720, or maybe the structure of the gltf changed.
I fixed it by using updating the testbed to use a more robust method of finding the correct entity as is done in
animated_mesh
.