Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EntityHashMap::new and EntityHashSet::new const #17615

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Make EntityHashMap::new and EntityHashSet::new const #17615

merged 1 commit into from
Jan 30, 2025
+2 −2

Conversation

Jondolf
Copy link
Contributor

@Jondolf Jondolf commented Jan 30, 2025 •
edited
Loading

Objective

#16912 turned EntityHashMap and EntityHashSet into proper newtypes instead of type aliases. However, this removed the ability to create these collections in const contexts; previously, you could use EntityHashSet::with_hasher(EntityHash), but it doesn't exist anymore.

Solution

Make EntityHashMap::new and EntityHashSet::new const methods.

@Jondolf Jondolf changed the title Make EntityHashMap::new and EntityHashSey::new const Make EntityHashMap::new and EntityHashSet::new const Jan 30, 2025
@Jondolf Jondolf added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 30, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 30, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 30, 2025
Merged via the queue into bevyengine:main with commit 59697f9 Jan 30, 2025
35 checks passed
@Jondolf Jondolf deleted the const-entity-hash-map-and-set branch January 30, 2025 22:35
@Jondolf Jondolf mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jondolf @alice-i-cecile