Fix update_image_content_size_system to use the camera target's scale factor
#17614
+50
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…camera target's scale factor, rather Also changed the size stored in `ImageNodeSize` to physical pixels. It's only used in change detection and by using physical coords we can avoid having to track scale factor separately.
update_image_content_size_system so that it uses the correct scale factorupdate_image_content_size_system so that it uses the correct scale factor
update_image_content_size_system so that it uses the correct scale factorupdate_image_content_size_system to use its target's scale factor
update_image_content_size_system to use its target's scale factorupdate_image_content_size_system to use the camera target's scale factor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Update UI image node size on changes to its camera target's scale factor.
Fixes #17613
Solution
Query for the camera target and use its scale factor.
Also changes the size stored in
ImageNodeSizeto physical pixels. It's only used in change detection and by using physical coords we can avoid having to track scale factor separately.Testing
If you run the example from #17613 you'll see that the image sizes are updated correctly now.