fix: NO_SUCH_TABLE regex

src/shillelagh/backends/apsw/db.py

@@ -83,7 +83,7 @@
     int(number) for number in apsw.sqlitelibversion().split(".")
 )
 
-NO_SUCH_TABLE = re.compile("(?:SQLError: )?no such table: (?P<uri>.*)")
+NO_SUCH_TABLE = re.compile("no such table: (?P<uri>.*)")
 DEFAULT_SCHEMA = "main"
 
 CURSOR_METHOD = TypeVar("CURSOR_METHOD", bound=Callable[..., Any])
@@ -250,7 +250,7 @@ def execute(
                 break
             except apsw.SQLError as ex:
                 message = ex.args[0]
-                if match := NO_SUCH_TABLE.match(message):
+                if match := NO_SUCH_TABLE.search(message):
                     # create the virtual table
                     uri = match.groupdict()["uri"]
                     self._create_table(uri)

tests/backends/apsw/db_test.py

@@ -13,7 +13,12 @@
 from pytest_mock import MockerFixture
 
 from shillelagh.adapters.registry import AdapterLoader, UnsafeAdaptersError
-from shillelagh.backends.apsw.db import Connection, connect, convert_binding
+from shillelagh.backends.apsw.db import (
+    NO_SUCH_TABLE,
+    Connection,
+    connect,
+    convert_binding,
+)
 from shillelagh.exceptions import NotSupportedError, ProgrammingError
 from shillelagh.fields import Float, String, StringInteger
 
@@ -541,3 +546,19 @@ def test_best_index(mocker: MockerFixture) -> None:
         "some_adapter",
         VTModule(adapter),
     )
+
+
+@pytest.mark.parametrize(
+    "error,uri",
+    [
+        ("apsw.SQLError: no such table: dummy://", "dummy://"),
+        ("SQLError: no such table: dummy://", "dummy://"),
+        ("no such table: dummy://", "dummy://"),
+    ],
+)
+def test_no_such_table_search(error: str, uri: str) -> None:
+    """
+    Test ``NO_SUCH_TABLE`` search.
+    """
+    match = NO_SUCH_TABLE.search(error)
+    assert match and match.groupdict() == {"uri": uri}