feat(api): 40 implement referentiel import functionality with region academique, academie and departement support #4683
+3,595
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fef523 to
132f4d9
Compare
achorein
reviewed
Jan 28, 2025
apiv2/src/admin/core/referentiel/ReferentielImportTask.service.ts
Outdated
Show resolved
Hide resolved
...re/referentiel/regionAcademique/useCase/ImportRegionsAcademiques/ImportRegionsAcademiques.ts
Outdated
Show resolved
Hide resolved
2c4ec5a to
697c9bf
Compare
|
En plus du conflit, je vois un problème avec l'intégration du code de Johann sur l'import / désistement des classes et le mien. Je le règle. |
697c9bf to
c515010
Compare
Johannbr
reviewed
Jan 31, 2025
...rentiel/regionAcademique/useCase/ImporterRegionsAcademiques/dto/RegionAcademiqueImportDto.ts
Outdated
Show resolved
Hide resolved
c515010 to
a170ff7
Compare
Johannbr
reviewed
Jan 31, 2025
apiv2/src/admin/core/referentiel/ReferentielImportTask.service.ts
Outdated
Show resolved
Hide resolved
a170ff7 to
bb0c637
Compare
Johannbr
reviewed
Jan 31, 2025
apiv2/src/admin/infra/referentiel/regionAcademique/RegionAcademiqueMongo.provider.ts
Outdated
Show resolved
Hide resolved
Johannbr
reviewed
Jan 31, 2025
| }).compile(); | ||
|
|
||
|
|
||
| regionAcademiqueGateway = module.get<RegionAcademiqueGateway>(RegionAcademiqueGateway); |
There was a problem hiding this comment.
Je pense qu'on peut éviter toutes les références à Mongoose dans les tests, il y a un intérêt à découpler les tests aussi.
Que penses tu d'un helper : apiv2/test/admin/sejour/cle/EtablissementHelper.ts
There was a problem hiding this comment.
Oui, bonne idée
Johannbr
reviewed
Jan 31, 2025
| throw new RegionAcademiqueValidationError('Invalid format - zone'); | ||
| } | ||
|
|
||
| if (!regionAcademique.dateDerniereModificationSI || !isValidDate(regionAcademique.dateDerniereModificationSI)) { |
There was a problem hiding this comment.
sur la v2 il y a clockGateway : apiv2/src/shared/core/Clock.gateway.ts implémenté par ClockProvider qui dépend de date-fns
ça permet de repartir sur qqch de plus propre dans la gestion des dates
1e019be to
390e537
Compare
… academique support - Added ReferentielModule to handle import tasks related to regions academiques. - Introduced ReferentielImportTaskService for managing import logic. - Created RegionAcademiqueImportService for handling region-specific imports. - Implemented ImportReferentielController to manage API endpoints for imports. - Added necessary models, DTOs, and MongoDB repository for region academique. - Added tests for the new functionality. This commit enhances the API with the ability to import region academique data, improving data management capabilities. Add error reporting for RegionAcademique, handling validations for classes, and add some tests and fix some typos issues
- Renamed XslX types to XlsX across multiple files - Moved FileValidation interface to a common Referentiel module - Updated type references in mapper, model, and service files - Ensured consistent naming for Excel file-related types
- Moved column names and file validation logic to specific model files - Updated import task service to use ClockGateway for timestamp generation - Added todo list for future referentiel import improvements - Cleaned up imports and type references across referentiel modules - Prepared groundwork for additional referentiel import types
- Integrated Département referentiel import support - Updated ReferentielModule to include Département-related providers and services - Added Département import task type to ReferentielTaskType - Implemented import handling for Département in AdminTaskImportReferentielSelectorService - Updated test cases to support Département import - Marked Département referentiel task as completed in todo list
- Integrated Academie referentiel import support - Updated ReferentielModule to include Academie-related providers and services - Added Academie import task type to ReferentielTaskType - Implemented import handling for Academie in AdminTaskImportReferentielSelectorService - Removed deprecated DTO classes and replaced with Mapper pattern - Updated todo list to mark Academie referentiel import as completed
- Deleted unnecessary pre-save middleware for Academie, Departement, and RegionAcademique schemas - Removed TODO comments related to user and timestamp tracking - Simplified MongoDB provider configurations for referentiel entities
- Replaced enum with object-based FilePath configuration - Updated file upload paths to use dynamic FilePath mapping - Standardized file path generation for different referentiel import types - Simplified file path management across referentiel services
… across referentiel modules - Replaced direct date validation with ClockGateway's isValidDate method - Renamed Mapper classes to ImportMapper for consistent naming - Updated import use cases to use ClockGateway for date validation - Removed deprecated isValidDate function from snu-lib - Simplified date parsing and validation logic across Academie, Departement, and RegionAcademique imports
…epositories - Implemented deleteAll() method in AcademieGateway, DepartementGateway, and RegionAcademiqueGateway - Added corresponding deleteAll() implementations in MongoDB repositories - Created helper functions for deleting all entities in test helpers - Updated test cases to use new deleteAll() method for test data cleanup - Standardized data deletion approach across referentiel modules
…ement, and RegionAcademique repositories - Implemented detailed test cases for AcademieMongoRepository - Added comprehensive test coverage for DepartementMongoRepository - Updated RegionAcademiqueMongo.repository.spec.ts with improved test structure - Introduced helper methods for creating and deleting test data - Ensured consistent testing approach across referentiel repositories
390e537 to
445e712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the APIv2 with the ability to import region academique data, improving data management capabilities.
https://www.notion.so/jeveuxaider/Importer-les-nomenclatures-SI-SNU-12272a322d508095a937c7713fb4604d?pvs=4