[Feat] Ajout d'un bouton de validation du Diagnostic pour une projet #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etchegom J'ai fait une modification dans le model du projet (ajout de l'attribut is_diagnostic_done) pourrais-tu vérifier le model ainsi que la migration s'il te plait ? |
etchegom
reviewed
Jan 16, 2025
Comment on lines
91
to
107
| <div x-data="MarkDiagAsDone({{ request.user.id }}, {{ project.id }}, '{{ project.is_diagnostic_done }}' == 'True')"> | ||
| <header> | ||
| <h6 class="font-small text-uppercase fr-mb-1v">Diagnostic</h6> | ||
| </header> | ||
| <template x-if="displayDiagButton"> | ||
| <button class="fr-btn fr-btn--sm fr-btn--secondary fr-mt-2w fr-py-2w fr-mb-2w text-uppercase w-100 justify-content-center" | ||
| @click='handleClickMarkDiagAsDone' | ||
| data-cy="button-diag-project-done"> | ||
| <span class="fr-icon-double-check-line" aria-hidden="true"></span> Marquer l’appel de “diagnostic” comme fait | ||
| </button> | ||
| </template> | ||
| <template x-if="!displayDiagButton"> | ||
| <p class="fw-700 fr-my-1w" data-cy="diag-project-done"> | ||
| <span class="fr-icon-double-check-line" aria-hidden="true"></span> Appel de "diagnostic" effectué | ||
| </p> | ||
| </template> | ||
| </div> |
There was a problem hiding this comment.
A titre d'exemple, avec htmx, on pourrait se passer de créer le fichier MarkDiagAsDone.js.
Ca donnerait qq chose comme ça (non testé):
<div x-data="{displayDiagButton: false}">
<header>
<h6 class="font-small text-uppercase fr-mb-1v">Diagnostic</h6>
</header>
<template x-if="displayDiagButton">
<button class="fr-btn fr-btn--sm fr-btn--secondary fr-mt-2w fr-py-2w fr-mb-2w text-uppercase w-100 justify-content-center"
data-cy="button-diag-project-done"
hx-put={% url 'projects-project-detail' project.id %}
hx-vals='{"is_diagnostic_done": true}'
hx-on::after-request="displayDiagButton = true">
<span class="fr-icon-double-check-line" aria-hidden="true"></span> Marquer l’appel de “diagnostic” comme fait
</button>
</template>
<template x-if="!displayDiagButton">
<p class="fw-700 fr-my-1w" data-cy="diag-project-done">
<span class="fr-icon-double-check-line" aria-hidden="true"></span> Appel de "diagnostic" effectué
</p>
</template>
</div>
etchegom
reviewed
Jan 16, 2025
etchegom
reviewed
Jan 16, 2025
| is_diagnostic_done: true, | ||
| }); | ||
| if (response.status !== 200) { | ||
| throw new Error('Error while marking the diag as done'); |
There was a problem hiding this comment.
Ca envoie un message dans sentry quand on raise une erreur?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il s'agit de :
Décrivez vos changements
Ajout d'une partie diagnostic dans la présentation d'un projet, uniquement pour les membres du staff.
Resolve #852
Checklist d'acceptation de revue de code
Demandes