refactor(ETL): Utilser QuerySet et Serializer pour publier les cantines dans Metabase #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s sur Metabase afin d utiliser le serializer.
raphodn
reviewed
Jan 13, 2025
api/serializers/canteen.py
Outdated
| @@ -529,6 +532,8 @@ def get_is_managed_by_user(self, obj): | |||
|
|
|||
| # remember to update TD version if you update this | |||
| class CanteenTeledeclarationSerializer(serializers.ModelSerializer): | |||
| geo_data = {"department": {i.value: i.label for i in Department}, "region": {i.value: i.label for i in Region}} | |||
api/serializers/canteen.py
Outdated
|
|
||
|
|
||
| class CanteenMetabaseSerializer(serializers.ModelSerializer): | ||
| departments_lib = {i.value: i.label.split(" - ")[1] for i in Department} |
There was a problem hiding this comment.
pourquoi les rajouter à la class ? vu qu'ils sont déjà accessibles sous forme de constants dans un autre fichier
api/serializers/canteen.py
Outdated
| return obj.department | ||
|
|
||
| def get_departement_lib(self, obj): | ||
| return self.departments_lib[obj.department] |
There was a problem hiding this comment.
plutôt rajouter une méthode coté department_choices.py et y faire appel ici
(exemple similaire ci-dessous avec get_modele_economique)
Co-authored-by: Raphaël Odini <raphodn@users.noreply.github.com>
|
Je propose que le refactor du map_sectors() soit pris en compte dans une prochaine PR (il va y en avoir plusieurs pour prendre en compte tous les jeux de données) Suite du refactor dont faudra discuter ensemble d'ailleurs |
…ma-cantine into 4756-refacto-queryset-opendata
raphodn
approved these changes
Jan 13, 2025
raphodn
added a commit
that referenced
this pull request
Jan 17, 2025
…es dans Metabase (#4884) Co-authored-by: Raphaël Odini <raphodn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.