fix(Diagnostic): N'accepte pas les valeurs moins de 0 #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Il faudra que je relise à tête reposée, mais est-ce que cette PR va pas affecter les bilan des satellites qui déclarent les autres mesures egalim et pas l'appro car la cuisine centrale a déjà déclarée l'appro ? |
raphodn
reviewed
Dec 11, 2024
data/models/canteen.py
Outdated
| @@ -182,11 +184,16 @@ class Ministries(models.TextChoices): | |||
| ) | |||
| has_been_claimed = models.BooleanField(default=False, verbose_name="cette cantine a été revendiquée") | |||
|
|
|||
| daily_meal_count = models.IntegerField(null=True, blank=True, verbose_name="repas par jour") | |||
| yearly_meal_count = models.IntegerField(null=True, blank=True, verbose_name="repas par an (y compris livrés)") | |||
| daily_meal_count = models.IntegerField( | |||
There was a problem hiding this comment.
j'utiliserais plutôt le modèle que Django propose : PositiveIntegerField
raphodn
approved these changes
Dec 11, 2024
56df578 to
40e2120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4503
Contexte : on gerais la validation de > 0 sur le front avec
validators.greaterThanZero, mais pas côté modèle alors c'est possible de créer des diagnostics dans l'admin avec des valeurs < 0 ainsi que avec l'import et l'API (j'imagine, j'ai pas testé l'API).Avec cette PR, je refactore la définition des champs pour permettre un ajout rapide du validator.
J'ai remarqué qu'on a d'autre champs qui ont le même souci, même si ajd c'est pas un problème parce qu'ils sont accèder que depuis le front (ah peut-être pas purchases)