Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Création modèle fiche action #4158

Merged
merged 10 commits into from
Jul 22, 2024
Merged

Conversation

valleepa
Copy link
Collaborator

No description provided.

@valleepa valleepa added the CMS label Jul 17, 2024
@valleepa valleepa requested review from hfroot and qloridant July 17, 2024 10:40
@valleepa valleepa self-assigned this Jul 17, 2024
@valleepa valleepa linked an issue Jul 17, 2024 that may be closed by this pull request
10 tasks
Copy link
Collaborator

@hfroot hfroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je peux pas tester bcp car il faut faire python manage.py makemigrations pour ajouter ce modèle dans la BDD

cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/models/actionsheet.py Outdated Show resolved Hide resolved
cms/viewsets/actionsheet.py Outdated Show resolved Hide resolved
This viewset allows using actionsheets on wagtail admin.
"""
model = ActionSheet
icon = "doc-full"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca aurait été bien, mais c'est déja l'icône de Workflow . P-e le mieux serait d'ajouter une icône, car la plupart de celles proposées par wagtail sont déja utilisées quelque part
image

@valleepa valleepa requested a review from hfroot July 18, 2024 12:35
Copy link
Collaborator

@hfroot hfroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faut ajouter les migrations

cms/models/wasteaction.py Outdated Show resolved Hide resolved
cms/viewsets/wasteaction.py Outdated Show resolved Hide resolved
@hfroot
Copy link
Collaborator

hfroot commented Jul 22, 2024

Normalement c'est bon, j'attends le test de la migration de @qloridant avant approuver la PR

@hfroot hfroot self-requested a review July 22, 2024 12:04
Copy link
Collaborator

@hfroot hfroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Après la confirmation de Quentin pour les migrations, tout paraît bon pour moi :)

@valleepa valleepa merged commit e1c3cfe into staging Jul 22, 2024
5 checks passed
@valleepa valleepa deleted the 4127-création-modèle-fiche-action-1 branch July 23, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Création modèle Fiche Action
3 participants