Améliorer le message d'erreur de validation des nombres entiers #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecks in decimal places and integer validators; put number format validator first in canteen form
|
@alemangui not sure why this was in draft, apologies if it turns out to be rubbish code |
alemangui
requested changes
Jan 19, 2024
Co-authored-by: Alejandro M Guillén <alejandro@amguillen.dev>
alemangui
approved these changes
Jan 19, 2024
|
Semble ok pour moi sur staging. GO pour prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the check for is base 10 a while back, but unfortunately the error message assumed that the number expected was decimal. This PR fixes that.
I haven't gone through all uses of isInteger and decimalPlaces, I suggest that is done in a second PR or as and when we spot them. Basically, these two should be the first in a list of validators so that the appropriate number format error message shows up. I wanted, however, to keep the base 10 check in all validators with numbers so that if the isInteger or decimalPlaces validators are forgotten, we still have the check.
Let me know though if you'd like to discuss approach more, maybe it would be better to not expect us/future devs to remember and throw a bigger error. Or an error just to the console ? As a reminder to use isInteger or decimalPlaces first.