🔥 Ne réécrie pas la méthode update d'une question qcm #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marouria
commented
Nov 26, 2024
Comment on lines
-51
to
-71
| def update | ||
| if @question.update(question_params) | ||
| redirect_to admin_question_qcm_path | ||
| else | ||
| render :edit, status: :unprocessable_entity | ||
| end | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def question_params | ||
| params.require(:question_qcm).permit( | ||
| :categorie, :libelle, :nom_technique, :description, | ||
| :metacompetence, :type_qcm, :illustration, :supprimer_illustration, | ||
| :supprimer_audio_intitule, | ||
| :supprimer_audio_modalite_reponse, | ||
| :supprimer_audio_consigne, | ||
| choix_attributes: %i[id intitule audio type_choix _destroy nom_technique], | ||
| transcriptions_attributes: %i[id categorie ecrit audio _destroy] | ||
| ) | ||
| end |
There was a problem hiding this comment.
J'ai l'impression que ça ne sert à rien et c'est difficile à maintenir car il faut ne pas oublier de mettre à jour la liste des params. Dans ce cas précis ça ne mettait donc pas à jour le champs :demarrage_audio_modalite_reponse
On ne le fait pas pour les autres types de questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.