Eva 229 le superadmin peut parametrer une question saisie pour litteratie #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3ef90f to
99814b5
Compare
ea23a31 to
61d953e
Compare
cprodhomme
reviewed
Nov 19, 2024
| def ajoute_saisies(reponse, index) | ||
| columns = %w[intitule nom_technique type_choix] | ||
| columns.each_with_index do |col, i| | ||
| @sheet[0, 11 + (index * 3) + i] = "reponse_#{index + 1}_#{col}" |
There was a problem hiding this comment.
ca représente quoi (index * 3) + i ?
There was a problem hiding this comment.
C'est l'algo qui permet de calculer le numéro de la colonne. J'ai repris ce qui a été fait pour les autres types de questions. Ici on spécifie qu'on a besoin de 3 colonnes pour chaque réponse.
J'ai donc remplacé par columns.size , également dans ajoute_reponseset ajoute_choix
| columns = %w[intitule nom_technique type_choix] | ||
| columns.each_with_index do |col, i| | ||
| @sheet[0, 11 + (index * 3) + i] = "reponse_#{index + 1}_#{col}" | ||
| @sheet[@ligne, 11 + (index * 3) + i] = reponse.send(col) |
There was a problem hiding this comment.
C'est pas forcément une bonne pratique la méta-programmation (send), cela rend le code complexe et difficile à maintenir 🤔
There was a problem hiding this comment.
J'ai réutilisé la fonctionnalité qui a été mise en place dans ajoute_choix et ajoute_reponses`
…oix pour apporter de la graduation dans le comptage des scores
…texte_a_trou et plusieurs réponses
…t en fonction du nombre de paramètre pour le type de réponse
61d953e to
0a9ca30
Compare
cprodhomme
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.