Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L'admin peut importer le contenu d'une question #1716

Merged
merged 9 commits into from
Nov 1, 2024
Merged

L'admin peut importer le contenu d'une question #1716

merged 9 commits into from
Nov 1, 2024

Conversation

marouria
Copy link
Contributor

No description provided.

@marouria marouria changed the title 📝 Cadrage L'admin peut exporter le contenu d'une question Oct 28, 2024
@marouria marouria force-pushed the EVA-209-ladmin-peut-importer-le-contenu-dune-question branch 4 times, most recently from 07e6601 to ac893ca Compare October 30, 2024 05:35
@marouria marouria changed the title L'admin peut exporter le contenu d'une question L'admin peut importer le contenu d'une question Oct 30, 2024
@marouria marouria force-pushed the EVA-209-ladmin-peut-importer-le-contenu-dune-question branch 10 times, most recently from d5103f7 to c87a63d Compare October 31, 2024 13:24
cprodhomme
cprodhomme reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@cprodhomme cprodhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelque chose me dit que tout ce refacto à eu lieu suite au mécontentement de Rubocop :D

J'aurais tendance à vouloir faire le refacto inverse.
C'est à dire de créer une classe parente ImportXls de ImportQuestion

Le but de cette classe parente serait de gérer tout ce qui concerne l'import d'XLS en général.
Tandis que ImportQuestion hériterai de tout ca, tout en ayant l'ensemble de la logique propre aux questions

app/models/import_question.rb Outdated Show resolved Hide resolved
app/models/import_question_headers.rb Outdated Show resolved Hide resolved
@marouria marouria force-pushed the EVA-209-ladmin-peut-importer-le-contenu-dune-question branch 2 times, most recently from 53f7ce6 to d51c268 Compare October 31, 2024 14:59
cprodhomme
cprodhomme reviewed Oct 31, 2024
View reviewed changes
app/models/import_question.rb Outdated Show resolved Hide resolved
app/models/import_xls.rb Outdated Show resolved Hide resolved
app/models/import_question.rb Outdated Show resolved Hide resolved
app/models/import_question.rb Outdated Show resolved Hide resolved
app/models/import_question.rb Outdated Show resolved Hide resolved
@marouria marouria force-pushed the EVA-209-ladmin-peut-importer-le-contenu-dune-question branch 2 times, most recently from 3537c95 to 70d47a3 Compare October 31, 2024 16:09
@marouria marouria force-pushed the EVA-209-ladmin-peut-importer-le-contenu-dune-question branch from 70d47a3 to 8e4aff3 Compare November 1, 2024 07:56
@marouria marouria marked this pull request as ready for review November 1, 2024 07:58
@marouria marouria merged commit ae956a7 into develop Nov 1, 2024
5 checks passed
@marouria marouria deleted the EVA-209-ladmin-peut-importer-le-contenu-dune-question branch November 1, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprodhomme cprodhomme cprodhomme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marouria @cprodhomme