Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peut supprimer le responsable de suivi depuis la show d'une évaluation #1415

Merged
merged 1 commit into from
Jan 25, 2023
Merged

peut supprimer le responsable de suivi depuis la show d'une évaluation #1415

merged 1 commit into from
Jan 25, 2023

Conversation

marouria
Copy link
Contributor

@marouria marouria commented Jan 20, 2023 •
edited
Loading

Capture d’écran 2023-01-23 à 12 56 25
Capture d’écran 2023-01-23 à 12 56 43
Capture d’écran 2023-01-23 à 12 57 02

@marouria
Copy link
Contributor Author

🎁 (3) Pouvoir retirer le responsable de suivi

@marouria marouria marked this pull request as draft January 20, 2023 14:15
@marouria marouria force-pushed the 1609- branch 3 times, most recently from 9bfd4fd to 682a912 Compare January 20, 2023 14:35
@marouria marouria marked this pull request as ready for review January 20, 2023 14:36
etienneCharignon
etienneCharignon reviewed Jan 23, 2023
View reviewed changes
app/assets/stylesheets/admin/composants/_tags.scss Outdated
padding-right: .25rem;
}
#lien-supprimer {
margin-left: .75rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne sais pas pourquoi, mais chez moi, il manque aussi une marge à droite et qu'il y a un problème de centrage vertical.
Capture d’écran 2023-01-23 à 10 41 38

Copy link
Member

@etienneCharignon etienneCharignon Jan 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me paraît chelou de styler un id… on avait parlé d'avoir plusieurs responsables de suivi un jour.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ignore si le dernier commit corrige tout, mais maintenant, j'ai ça :
Capture d’écran 2023-01-23 à 14 16 03

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est parce que la pseudo-class css has() n'est pas supporté par firefox 😢
Sinon il n'y a pas de marge à droite, j'ai remis les bonnes captures d'écran en commentaire de la PR.

@marouria marouria force-pushed the 1609- branch 2 times, most recently from c6ab937 to cdc16bd Compare January 23, 2023 14:28
@cprodhomme cprodhomme merged commit 98d2854 into develop Jan 25, 2023
@cprodhomme cprodhomme deleted the 1609-🎁-3-pouvoir-retirer-le-responsable-de-suivi branch January 25, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etienneCharignon etienneCharignon etienneCharignon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marouria @etienneCharignon @cprodhomme