Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aos Presets #464

Merged
merged 18 commits into from
May 12, 2024
Merged

Aos Presets #464

merged 18 commits into from
May 12, 2024

Conversation

ChrisRosser
Copy link
Contributor

Hi Everyone,

I have just updated my presets for BF4.5 and was wondering if it would be appropriate to merge them into the main presets repo?

Lots of pilots are using them from my repo on BF 4.3 4.4 and now 4.5 so they should be very safe to merge.

Let me know if its appropriate or not!

Thanks,

Chris

First release of presets
indexer update
commit 7bb67bf
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 10:45:47 2024 +0100

    update

commit 8dd0d55
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 10:45:02 2024 +0100

    update

commit ad24af9
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 10:38:39 2024 +0100

    update

commit 5efa223
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 10:37:12 2024 +0100

    update with prop options

commit 1be5cef
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 10:21:16 2024 +0100

    remove index files
update rates

Update AOS_rates.txt
commit 44ba2f3
Merge: 6818385 49b10c9
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Thu May 9 15:21:50 2024 +0100

    Merge branch 'betaflight:master' into aos-rc

commit 6818385
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Thu May 9 12:24:49 2024 +0100

    add AOS 4

commit 9fe0c5e
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Thu May 9 09:58:41 2024 +0100

    added rates

    update rates

    Update AOS_rates.txt

commit 5de0e28
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 11:50:24 2024 +0100

    change to community status

    update index

commit 2e84481
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 11:34:12 2024 +0100

    fix line endings

commit 5cf3f46
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 10:53:08 2024 +0100

    Squashed commit of the following:

    commit 7bb67bf
    Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
    Date:   Wed May 8 10:45:47 2024 +0100

        update

    commit 8dd0d55
    Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
    Date:   Wed May 8 10:45:02 2024 +0100

        update

    commit ad24af9
    Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
    Date:   Wed May 8 10:38:39 2024 +0100

        update

    commit 5efa223
    Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
    Date:   Wed May 8 10:37:12 2024 +0100

        update with prop options

    commit 1be5cef
    Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
    Date:   Wed May 8 10:21:16 2024 +0100

        remove index files

commit f0b4b68
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 10:06:24 2024 +0100

    index update

commit 127178b
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 09:59:43 2024 +0100

    update to BF 4.5

commit 40f4342
Merge: 01cc234 beab257
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Wed May 8 09:33:55 2024 +0100

    Merge branch 'master' into aos-rc

commit 01cc234
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Mon May 15 21:28:59 2023 +0100

    Update aos_ul5_tune.txt

    indexer update

commit 832f604
Author: ChrisRosser <41840611+ChrisRosser@users.noreply.github.com>
Date:   Thu May 4 15:39:28 2023 +0100

    First release of presets

    First release of presets
@limonspb
Copy link
Member

sould be ok. Its a lot, but they seem to be good. Ill go through them this weekend more carefully, see if i can spot anything to fix.

@limonspb
Copy link
Member

went thought, have a few minor things:

Options like down below can't be checked by default inside the TUNE/FILTERS because these parameters technically personal preferences, and not the tunes.

SO you can have them as options, but should not be applied by default. Only when user mindfully clicks on them:

#$ OPTION_GROUP BEGIN: Check all of these (recommended)

    # -- VBat sag compensation --
    #$ OPTION BEGIN (CHECKED): Full battery sag compensation
        set vbat_sag_compensation = 100
        set vbat_sag_lpf_period = 2
    #$ OPTION END

    # -- Stick behaviour --
    #$ OPTION BEGIN (CHECKED): No stick deadband
        set deadband = 0
        set yaw_deadband = 0
    #$ OPTION END

    # -- Startup and arming --
    #$ OPTION BEGIN (CHECKED): Arm at any angle
        set small_angle = 180
    #$ OPTION END

    # -- Prop direction --
    #$ OPTION BEGIN (CHECKED): Props out (check motor direction!)
        set yaw_motors_reversed = ON
    #$ OPTION END

#$ OPTION_GROUP END

@ChrisRosser
Copy link
Contributor Author

@limonspb No problem I will set all those options as default unchecked 👍

@ChrisRosser
Copy link
Contributor Author

@limonspb I've made those changes as requested.

@limonspb limonspb merged commit 5f99859 into betaflight:master May 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants