Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created UWL Whoop tune by FreshBread #454

Merged

Conversation

Stampede10343
Copy link
Contributor

This is a Underground Whoop League (UWL) tune created by FreshBread.

Copy link
Member

@limonspb limonspb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry just saw the PR.
Could you plz add filter defaults include.
Also you don't have to type all PIDs/Filter values, if you are using sliders.
You can just list slider values that are different from defaults
And add
"simplified_tuning apply" at the end.
Thanks!

@Stampede10343
Copy link
Contributor Author

@limonspb I believe I've got it fixed up, take a look when you get a chance, thanks!

@limonspb
Copy link
Member

limonspb commented May 6, 2024

@limonspb I believe I've got it fixed up, take a look when you get a chance, thanks!

Sweet thanks!
Few more notes if you don't mind:
Title should prolly include "whoop 75mm" so people could see right away it's for whoops.

In the description I see it's mentioning kaack. Since this is 4.5 preset, you don't need kaack, can just flash with RACE_PRO option selected from the drop-down of options.

RPM limit better be in a separate option from setting up filters, and RPM limit option needs to be unchecked by default.
The RPM filters setting, motor poles etc can be without option, if you want.

BMI option better be unchecked prolly?

@Stampede10343
Copy link
Contributor Author

@limonspb I believe I've got it fixed up, take a look when you get a chance, thanks!

Sweet thanks! Few more notes if you don't mind: Title should prolly include "whoop 75mm" so people could see right away it's for whoops.

In the description I see it's mentioning kaack. Since this is 4.5 preset, you don't need kaack, can just flash with RACE_PRO option selected from the drop-down of options.

RPM limit better be in a separate option from setting up filters, and RPM limit option needs to be unchecked by default. The RPM filters setting, motor poles etc can be without option, if you want.

BMI option better be unchecked prolly?

Sounds good. I was wondering how to enable it in 4.5, good to know about that option!

@Stampede10343 Stampede10343 requested a review from limonspb May 9, 2024 15:03
@limonspb
Copy link
Member

was wondering about this:

#$ OPTION BEGIN (UNCHECKED): UWL RPM Limiter Settings
set dshot_bidir = ON
set motor_poles = 12
set rpm_limit = ON
set rpm_limit_value = 31500
#$ OPTION END

basically it means if someone doesn't want to apply the spec limit, he also won't have bidirectional dshot?

@Stampede10343
Copy link
Contributor Author

was wondering about this:

#$ OPTION BEGIN (UNCHECKED): UWL RPM Limiter Settings set dshot_bidir = ON set motor_poles = 12 set rpm_limit = ON set rpm_limit_value = 31500 #$ OPTION END

basically it means if someone doesn't want to apply the spec limit, he also won't have bidirectional dshot?

I think the main focus is the UWL spec, if someone wants RPM filtering I feel like its fine to let them do that on their own. I'm unsure how well this tune would work on a lightweight or more 'standard' 75mm so I didn't focus too much on the non UWL whoops

@limonspb limonspb merged commit 02c181f into betaflight:master May 22, 2024
1 check passed
@Stampede10343 Stampede10343 deleted the feature/uwl-freshbread-tune-preset branch May 22, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants